Opened on 01/17/2017 at 05:42:42 AM

Closed on 05/29/2017 at 03:41:24 PM

#4806 closed change (rejected)

Update buildtools dependency for Microsoft Edge bookmark

Reported by: oleksandr Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by oleksandr)


We have added improved support for Edge builds in #4719 and now we need to use that code in build process.

NOTE: In I have referenced a non-existing buildtools version 84c599613ecb. This was since fixed in where a correct version 4cea55c4bdc0 was referenced. This should update buildtools further to 1b8ddae7f0b3, however this was already done in This issue can be closed now.

What to change

Update buildtools reference in adblockpluschrome repository in edge bookmark to the latest version.

Attachments (0)

Change History (7)

comment:1 Changed on 01/17/2017 at 05:43:09 AM by oleksandr

  • Component changed from Unknown to Platform
  • Platform changed from Unknown / Cross platform to Edge
  • Ready set

comment:2 Changed on 01/17/2017 at 06:16:33 AM by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 01/17/2017 at 06:51:32 AM by kzar

You mentioned that the revision was already updated in a different commit, but that there was a mistake there. I think that should be mentioned in this issue description along with a link to the commit. IMO this is a defect issue fixing that regression rather than a standard change issue to update the dependency.

comment:4 Changed on 03/16/2017 at 09:13:59 AM by kzar

What's the status of this issue Ollie?

comment:5 Changed on 03/17/2017 at 02:03:52 PM by oleksandr

  • Description modified (diff)

comment:6 Changed on 03/17/2017 at 02:04:05 PM by oleksandr

Update the description. This issue can be closed.

comment:7 Changed on 05/29/2017 at 03:41:24 PM by kzar

  • Resolution set to rejected
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.