Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4817 closed change (fixed)

Update committee application form on acceptableads.com

Reported by: jobp Assignee: juliandoucette
Priority: Unknown Milestone:
Module: Websites Keywords:
Cc: vickyyu, saroyanm, innerself, athornburgh, lisabielik Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29373766

Description (last modified by juliandoucette)

Background

As part of #4843 we would like to update the following on the Acceptable Ads committee form.

What to change

  • Add Ad-blocker user option to Stakeholder group select
  • Change Consumer Group option to Digital Rights Organization select
  • Change the page title to Apply to join the committee
  • Replace the two paragraphs at the top of the page with the following text
Do you want to help create a new standard of advertising and improve the ad experience for millions of ad-blocking users? If so, fill out the form below!

Attachments (1)

Screen Shot 2017-02-07 at 11.16.00.png (116.3 KB) - added by juliandoucette 3 years ago.

Download all attachments as: .zip

Change History (29)

comment:1 Changed 3 years ago by juliandoucette

  • Cc saroyanm added
  • Priority changed from Unknown to P1
  • Ready set

@jobp: I think this is time sensitive. Hence P1. Please correct me if I am wrong.

comment:2 Changed 3 years ago by saroyanm

  • Description modified (diff)

comment:3 Changed 3 years ago by juliandoucette

  • Priority changed from P1 to P2

comment:4 Changed 3 years ago by saroyanm

  • Blocking 4843 added

comment:5 Changed 3 years ago by saroyanm

  • Summary changed from Add a new "Stakeholder group" to the application form on https://acceptableads.com/en/committee/apply to Add a new "Stakeholder group" on Apply for committee page

Note: make sense to check the backend implementation first -> https://issues.adblockplus.org/ticket/4377

comment:6 Changed 3 years ago by saroyanm

  • Cc innerself athornburgh added
  • Description modified (diff)

comment:7 Changed 3 years ago by juliandoucette

  • Owner set to juliandoucette

comment:8 Changed 3 years ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Summary changed from Add a new "Stakeholder group" on Apply for committee page to Update committee application form on acceptableads.com

@athornburgh You tacked on extra requirements to "what to change" that made the summary invalid.

Can we push this entire change asap?

comment:9 in reply to: ↑ description ; follow-up: Changed 3 years ago by saroyanm

  • Cc lisabielik added

Replying to jobp:

Background

To accurately reflect the last changes in the bylaws since September, a seat will be awarded to an adblocking user. This option should be added to the dropdown menu on https://acceptableads.com/en/committee/apply

What to change

On the application form on ​https://acceptableads.com/en/committee/apply, please change the following:

  • Under the "Stakeholder group" dropdown:
  • Add a category for "Ad blocker user"

Adblocker user instead of Ad blocker user

@lisa @job: can you please confirm that the ticket text is correct ?

comment:10 in reply to: ↑ 9 Changed 3 years ago by lisabielik

Replying to saroyanm:

Replying to jobp:

Background

To accurately reflect the last changes in the bylaws since September, a seat will be awarded to an adblocking user. This option should be added to the dropdown menu on https://acceptableads.com/en/committee/apply

What to change

On the application form on ​https://acceptableads.com/en/committee/apply, please change the following:

  • Under the "Stakeholder group" dropdown:
  • Add a category for "Ad blocker user"

Adblocker user instead of Ad blocker user

@lisa @job: can you please confirm that the ticket text is correct ?

It should be Ad-blocker user

comment:11 Changed 3 years ago by juliandoucette

@lisa can you confirm that the rest of the text (that was added and that which remains) is correct?

comment:12 follow-up: Changed 3 years ago by juliandoucette

  • Description modified (diff)

Who can confirm that what we send to the backend is correct?

(Can we send any option value, or does someone have to configure it first?)

comment:13 Changed 3 years ago by jobp

LGTM

comment:14 in reply to: ↑ 12 Changed 3 years ago by saroyanm

Replying to juliandoucette:

Who can confirm that what we send to the backend is correct?

(Can we send any option value, or does someone have to configure it first?)

Check my comment here, I had a quick look through sitescript implementation, seems like we are fine here, what ever new option we will add into that selectbox the value will be sent to the email.

Anyway after pushing the changes, make sense to ask Job to test, to be 100% sure.

comment:15 Changed 3 years ago by juliandoucette

  • Priority changed from P2 to Unknown
  • Ready unset
  • Sorry athornburgh, it was saroyanm that tacked on the extra requirements not you
    • saroyanm you forgot to update ready, summary, and description -> background after you changed description -> what to change
  • Lisa can you please review the contents of this ticket again?
    • And LGTM when it's approved
Last edited 3 years ago by juliandoucette (previous) (diff)

comment:16 Changed 3 years ago by jobp

Anything I can do to move this forward? We are pushing the press release out today / tomorrow - would be nice to have the form updated by then.

comment:17 follow-up: Changed 3 years ago by juliandoucette

@lisabielik has to re-LGTM the content or @athornburgh has to approve us pushing this change temporarily without @lisabielik's approval. And then @saroyanm has to LGTM the code review.

Last edited 3 years ago by juliandoucette (previous) (diff)

comment:18 in reply to: ↑ 17 Changed 3 years ago by lisabielik

Replying to juliandoucette:

@lisabielik has to re-LGTM the content or @athornburgh has to approve us pushing this change temporarily without @lisabielik's approval. And then @saroyanm has to LGTM the code review.

@juliandoucette:

The text on this page should read:

Do you want to help create a new standard of advertising and improve the ad experience for millions of ad-blocking users? If so, fill out the form below!

comment:19 Changed 3 years ago by juliandoucette

  • Description modified (diff)
  • Ready set

comment:20 Changed 3 years ago by juliandoucette

  • Ready unset

@lisabielik I think that makes the page title redundant doesn't it?

Page title: Want to join the Acceptable Ads Committee? Fill out the form below!
Paragraph 1: Do you want to help create a new standard of advertising and improve the ad experience for millions of ad-blocking users? If so, fill out the form below!

(I will attach a screenshot)

Changed 3 years ago by juliandoucette

comment:21 Changed 3 years ago by juliandoucette

  • Description modified (diff)

I just checked the wireframes again and found a different title. I'm going to go out on a limb and say that someone forgot to add this to the ticket spec and add it myself + update the code review.

Aaron or Lisa can you please confirm?

Thanks! :)

comment:22 Changed 3 years ago by athornburgh

The page title should be:

"Apply to join the committee"

comment:23 Changed 3 years ago by athornburgh

I approve all other content changes.

comment:24 Changed 3 years ago by juliandoucette

  • Ready set

comment:26 Changed 3 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:27 Changed 3 years ago by juliandoucette

  • Blocking 4843 removed
  • Milestone set to acceptableads.com/committee 160301

comment:28 Changed 3 years ago by juliandoucette

  • Milestone acceptableads.com/committee 160301 deleted
Note: See TracTickets for help on using tickets.