Changes between Initial Version and Version 5 of Ticket #4828


Ignore:
Timestamp:
01/08/2018 12:48:33 PM (23 months ago)
Author:
sergz
Comment:

Replying to kzar:

Well unless I'm mistaken both adblockplusie and adblockplus are deprecated now, so we'd just be removing the duplication between adblockpluschrome and libadblockplus. (Also since those links are using the master bookmark the line numbers are wrong now.) Would you mind updating the description?

The links are updated but the links for FF and IE are left because of the following reasons. In FF the implementation significantly differs from the implementation in other projects and it's not clear what should be chosen. The status of IE is not finally deprecated, so it still can happen that Oleksandr decides to update libadblockplus in IE at some point.

I have also added @wspee into CC in order to firstly synchronize the desired behaviour with new options page, @wspee could you please tell what subscriptions, when and how should be added?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4828

    • Property Cc greiner kzar wspee added; trev removed
  • Ticket #4828 – Description

    initial v5  
    22We have several implementations in different places of one functionality which does the same thing - it adds default subscriptions, in particular, including acceptable ads, on the first run. 
    33Firefox: https://github.com/adblockplus/adblockplus/blob/master/lib/ui.js#L803 
    4 Chrome: https://github.com/adblockplus/adblockpluschrome/blob/master/lib/subscriptionInit.js#L115 
    5 Libadblockplus: https://github.com/adblockplus/libadblockplus/blob/master/lib/init.js#L44 
     4Chrome: https://github.com/adblockplus/adblockpluschrome/blob/e1da5f862b2f0548b1e222525bfe18cdb44dd4e9/lib/subscriptionInit.js#L150 
     5Libadblockplus: https://github.com/adblockplus/libadblockplus/blob/72dd22b538b27b46046a42d670e909f5f332ccf2/lib/init.js#L60 
    66Internet Explorer: https://github.com/adblockplus/adblockplusie/blob/847b062636bf5ed9517f8e78d448a543c1d466f4/src/plugin/PluginClass.cpp#L754 
    77 
    88=== What to change === 
     9- align with new options page and check that there is no such logic in adblockplusui repository 
    910- add a unified implementation into adblockpluscore 
    1011- make changes in the mentioned above projects