Changes between Version 11 and Version 16 of Ticket #4829


Ignore:
Timestamp:
09/29/2017 08:52:21 AM (16 months ago)
Author:
kzar
Comment:

(Copying in Thomas since this is now an adblockplusui change.)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4829

    • Property Status changed from reviewing to reopened
    • Property Platform changed from Chrome to Unknown / Cross platform
    • Property Cc greiner added
    • Property Component changed from Platform to User-Interface
    • Property Blocking changed from to 5751
    • Property Blocked By changed from 4833 to
  • Ticket #4829 – Description

    v11 v16  
    1616=== Background === 
    1717The filter validation that produces the error "filter_invalid_domain" was introduced in #4450 but without an error text associated with it. Therefore adding a translatable string with the ID "filter_invalid_domain" to adblockplus/chrome/locale/en-US/global.properties should be sufficient to fix this issue. 
     18 
     19=== What to change === 
     20- Move the filter_* core strings from global.properties in adblockplus to new-options.json in  adblockplusui, synchronise the updated state for both projects with Crowdin. 
     21- Add the `filter_invalid_domain` string with the message of `"Invalid (or empty) domain specified"` .