Changes between Version 17 and Version 18 of Ticket #4829


Ignore:
Timestamp:
09/29/2017 08:55:46 AM (18 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4829 – Description

    v17 v18  
    1717The filter validation that produces the error "filter_invalid_domain" was introduced in #4450 but without an error text associated with it. Therefore adding a translatable string with the ID "filter_invalid_domain" to adblockplus/chrome/locale/en-US/global.properties should be sufficient to fix this issue. 
    1818 
     19The problem is the adblockplus repository is going away, we hardly want to add more strings there. So instead let's move the `filter_*` messages over into adblockplusui while we're at it. 
     20 
    1921=== What to change === 
    2022- Move the `filter_*` strings from global.properties in adblockplus to new-options.json in  adblockplusui, synchronise the updated adblockplusui project with Crowdin. (No need to remove the strings from adblockplus nor update that project in Crowdin, since it's going away.)