Changes between Version 2 and Version 4 of Ticket #4837


Ignore:
Timestamp:
01/27/2017 06:06:20 PM (4 years ago)
Author:
saroyanm
Comment:

The share overlay funcionality is broken, I've updated the ticket so we can fix it in the scope of this ticket and also implement the mobile behavior.

The only thing that I don't understand, what should be the behavior if we are hiding the overlay on the small screens ? Should we deeplink to the Help tab, where people can access our product pages ?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4837

    • Property Summary changed from Don't show share overlay on small screens to Fix share overlay and hide it on small screens
    • Property Owner set to saroyanm
  • Ticket #4837 – Description

    v2 v4  
    11=== Background === 
    2 As part of #1524 we should not show the share overlay implemented in #2381 on small screens. Note that the dimensions of the content of the share overlay are dynamic so we need to estimate what the threshold should be for categorizing the screen as "small". 
     2The share overlay functionality is broken and as part of #1524 we should not show the share overlay implemented in #2381 on small screens. Note that the dimensions of the content of the share overlay are dynamic so we need to estimate what the threshold should be for categorizing the screen as "small". 
    33 
    44At some point we should make the share overlay's content responsive as well. Thereby we could avoid checks like this one altogether. 
    55 
    66=== What to change === 
    7 Don't show the share overlay (see #2381) on screens with less than 800px width  (similar to implementation on the first-run page in #2018). 
     7Fix the share overlay functionality and hide the share overlay (see #2381) on screens with less than 800px width  (similar to implementation on the first-run page in #2018).