Opened on 01/24/2017 at 10:18:01 AM
Closed on 04/21/2017 at 10:39:43 AM
#4837 closed change (invalid)
Fix share overlay and hide it on small screens
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | new-settings-page |
| Cc: | greiner, wspee | Blocked By: | |
| Blocking: | #2706 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by saroyanm)
Background
The share overlay functionality is broken and as part of #1524 we should not show the share overlay implemented in #2381 on small screens. Note that the dimensions of the content of the share overlay are dynamic so we need to estimate what the threshold should be for categorizing the screen as "small".
At some point we should make the share overlay's content responsive as well. Thereby we could avoid checks like this one altogether.
What to change
Fix the share overlay functionality and hide the share overlay (see #2381) on screens with less than 800px width (similar to implementation on the first-run page in #2018).
Attachments (0)
Change History (7)
comment:1 Changed on 01/24/2017 at 10:21:57 AM by saroyanm
- Blocking 2706 added; 1524 removed
comment:2 Changed on 01/24/2017 at 04:34:41 PM by greiner
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
- Summary changed from Resolution optimization of share overlay to Don't show share overlay on small screens
comment:3 Changed on 01/27/2017 at 03:36:33 PM by saroyanm
- Owner set to saroyanm
comment:4 follow-up: ↓ 5 Changed on 01/27/2017 at 06:06:20 PM by saroyanm
- Description modified (diff)
- Summary changed from Don't show share overlay on small screens to Fix share overlay and hide it on small screens
comment:5 in reply to: ↑ 4 Changed on 01/27/2017 at 06:58:51 PM by greiner
Replying to saroyanm:
The only thing that I don't understand, what should be the behavior if we are hiding the overlay on the small screens ? Should we deeplink to the Help tab, where people can access our product pages ?
Good point. It should probably be the same behavior as when "Remove social media buttons" is enabled. On the first-run page that behavior is to have each button link to the respective site directly whereas here it is to hide the share button.
comment:6 Changed on 04/20/2017 at 06:25:11 PM by saroyanm
- Cc wspee added
@Winsley what are the plans regarding share overlay ?
Are we going to have share overlay ?
If so I think it make sense to convert this ticket into bitbucket ticket before closing I guess.
The share overlay funcionality is broken, I've updated the ticket so we can fix it in the scope of this ticket and also implement the mobile behavior.
The only thing that I don't understand, what should be the behavior if we are hiding the overlay on the small screens ? Should we deeplink to the Help tab, where people can access our product pages ?