Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#4838 closed change (fixed)

Use nodeunit framework for integration tests running in browser

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Core Keywords:
Cc: fhd Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29373596/

Description (last modified by fhd)

Background

#4726 introduced integration tests running in a headless browser via PhantomJS. These tests are currently using the QUnit framework however with a number of implications:

  • The boilerplate is significantly different from our other code.
  • An HTML file is required for each tests where a JS file should be enough.
  • The output format is very different and less informative than for the other tests.

What to change

Use PhantomJS directly in order to run our tests with the nodeunit framework (using the browser distribution we have in the nodeunit module already).

Change History (4)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by abpbot

comment:3 Changed 2 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 years ago by fhd

  • Description modified (diff)
Note: See TracTickets for help on using tickets.