Opened 5 years ago

Closed 2 years ago

#484 closed change (rejected)

Use mouseenter event for object tabs instead of mouseover

Reported by: trev Assignee: mga
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://github.com/adblockplus/adblockplus/pull/5

Description

Background

We are currently using the mouseover event to recognize when the mouse pointer enters an object tab lib/objectTabs.js, using mouseenter should be more efficient here.

What to change

Replace mouseover event by mouseenter and verify that it still works the same.

Change History (5)

comment:1 Changed 5 years ago by mga

Hi!
I would like to work on this bug, and I have already forked the repo from GitHub.

comment:2 Changed 5 years ago by trev

  • Owner set to mga

I reassigned this issue to you. See https://adblockplus.org/en/contribute-code for some general instructions. Note that dependent repositories currently won't be cloned automatically when working with git - you have to clone https://github.com/adblockplus/buildtools/ into the buildtools/ subdirectory manually.

comment:4 Changed 5 years ago by trev

  • Review URL(s) modified (diff)

comment:5 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.