Opened 4 years ago

Closed 11 months ago

Last modified 10 months ago

#4854 closed defect (rejected)

IsDocumentWhitelisted crashes

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: Anton Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



During testing i've found a crash in FilterEngine.isDocumentWhitelisted() invocation. It's used to get elemhide selectors list - if the doc is whitelisted, then returning empty selectors list. This is rare case and extremely difficult to reproduce (kind of concurrency).

How to reproduce

  1. start webview app (from libadblockplus-android repo)
  2. type "" and "ok" button
  3. wait for the app crash


Observed behaviour

The app crashes with an error:
TypeError: Object #<Object> has no method 'toLowerCase' at matcher.js:286

Expected behaviour

the method returns true or false and the app does not crash

Attachments (2)

js_crash.txt (25.6 KB) - added by asmirnov 4 years ago.
full app stacktrace
stacktrace2.txt (4.7 KB) - added by asmirnov 3 years ago.
new stacktrace

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by asmirnov

full app stacktrace

comment:1 Changed 4 years ago by asmirnov

url is not null as you can see "Requesting elemhide selectors from AdblockEngine for .." in the log

comment:2 Changed 4 years ago by asmirnov

domain is not null as you can see "Extracted domain ..." in the log

Changed 3 years ago by asmirnov

new stacktrace

comment:3 Changed 3 years ago by asmirnov

  • Cc Anton added
  • Priority changed from P3 to P2
  • Ready set

comment:4 Changed 3 years ago by sergz

  • Ready unset

It seems to be in the old version, I'm leaving it open for present in order to firstly obtain more details.

comment:5 Changed 3 years ago by asmirnov

it's confirmed to be some "old version"

comment:6 Changed 17 months ago by mjethani

Is this still relevant? If not, let's close it.

comment:7 Changed 17 months ago by asmirnov

I have no updates since touched it last time.
Feel free to close it if you feel so.

comment:8 Changed 16 months ago by bambamm22


Last edited 10 months ago by kzar (previous) (diff)

comment:9 Changed 11 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.