Opened on 01/31/2017 at 11:39:03 AM

Closed on 08/29/2019 at 05:43:52 PM

Last modified on 10/08/2019 at 05:50:52 PM

#4854 closed defect (rejected)

IsDocumentWhitelisted crashes

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: Anton Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



During testing i've found a crash in FilterEngine.isDocumentWhitelisted() invocation. It's used to get elemhide selectors list - if the doc is whitelisted, then returning empty selectors list. This is rare case and extremely difficult to reproduce (kind of concurrency).

How to reproduce

  1. start webview app (from libadblockplus-android repo)
  2. type "" and "ok" button
  3. wait for the app crash


Observed behaviour

The app crashes with an error:
TypeError: Object #<Object> has no method 'toLowerCase' at matcher.js:286

Expected behaviour

the method returns true or false and the app does not crash

Attachments (2)

js_crash.txt (25.6 KB) - added by asmirnov on 01/31/2017 at 11:39:26 AM.
full app stacktrace
stacktrace2.txt (4.7 KB) - added by asmirnov on 12/19/2017 at 07:42:48 AM.
new stacktrace

Download all attachments as: .zip

Change History (11)

Changed on 01/31/2017 at 11:39:26 AM by asmirnov

full app stacktrace

comment:1 Changed on 01/31/2017 at 11:40:19 AM by asmirnov

url is not null as you can see "Requesting elemhide selectors from AdblockEngine for .." in the log

comment:2 Changed on 01/31/2017 at 11:41:25 AM by asmirnov

domain is not null as you can see "Extracted domain ..." in the log

Changed on 12/19/2017 at 07:42:48 AM by asmirnov

new stacktrace

comment:3 Changed on 12/19/2017 at 07:43:53 AM by asmirnov

  • Cc Anton added
  • Priority changed from P3 to P2
  • Ready set

comment:4 Changed on 12/27/2017 at 09:49:58 AM by sergz

  • Ready unset

It seems to be in the old version, I'm leaving it open for present in order to firstly obtain more details.

comment:5 Changed on 12/27/2017 at 12:03:47 PM by asmirnov

it's confirmed to be some "old version"

comment:6 Changed on 03/16/2019 at 03:22:09 PM by mjethani

Is this still relevant? If not, let's close it.

comment:7 Changed on 03/25/2019 at 10:20:26 AM by asmirnov

I have no updates since touched it last time.
Feel free to close it if you feel so.

comment:8 Changed on 04/02/2019 at 04:18:19 PM by bambamm22


Last edited on 10/08/2019 at 05:50:52 PM by kzar

comment:9 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.