Changes between Version 1 and Version 2 of Ticket #4856


Ignore:
Timestamp:
02/02/2017 12:50:59 PM (2 years ago)
Author:
greiner
Comment:

I'm fine with the proposed changes but I'd suggest tackling the efficiency issue separately. The reason for that being that multiple input and output values were initially part of the messaging protocol but got rejected. Therefore we first need to agree on an appropriate way on how we can minimize the communication overhead between background page and other pages - requesting multiple values at once is only one possible approach.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4856

    • Property Priority changed from Unknown to P3
    • Property Ready set
  • Ticket #4856 – Description

    v1 v2  
    11=== Background === 
    2 We do use [https://hg.adblockplus.org/adblockplusui/file/tip/common.js#l27 getDocLink] function to assign redirectable, localized links. Usage of that function, both in new-options.js and firstRun.js is messy. 
     2We do use [https://hg.adblockplus.org/adblockplusui/file/tip/common.js#l27 getDocLink] function to assign redirectable, localized links. Usage of that function, both in new-options.js and firstRun.js is messy and inefficient due to unnecessary repetition. 
    33 
    44=== What to change === 
    5 * Use HTML element attribute to assign redirectable localized links (similar we do using data-action) [less messy code] 
    6 * Add ability to request list of redirectable localized links from messageresponder [efficiency]. 
     5Use the `data-doclink` attribute to assign links that use adblockplus.org/redirect to anchor tags on the page (similar to `data-i18n`). 
     6 
     7Note that as soon as the messaging API supports it, we could make use of the initialization code to aggregate all "app.get" messages into a single one to avoid unnecessary message passing.