Opened 3 years ago

Last modified 7 months ago

#4856 closed change

Reimplement getDocLink assignment in adblockplusUI — at Version 1

Reported by: saroyanm Assignee:
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by saroyanm)

Background

We do use getDocLink function to assign redirectable, localized links. Usage of that function, both in new-options.js and firstRun.js is messy.

What to change

  • Use HTML element attribute to assign redirectable localized links (similar we do using data-action) [less messy code]
  • Add ability to request list of redirectable localized links from messageresponder [efficiency].

Change History (1)

comment:1 Changed 3 years ago by saroyanm

  • Description modified (diff)

I created this as a part of current discussion:

  • Are changes fine with you @Thomas ?
  • I didn't make this blocker for #2706, let me know if you think it should be.
Last edited 3 years ago by saroyanm (previous) (diff)
Note: See TracTickets for help on using tickets.