Opened 3 years ago

Last modified 3 years ago

#4864 closed change

Start using ESLint for adblockpluschrome repository — at Version 2

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.13.3-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, Ross, rraceanu, philll, sclow Blocked By: #3692, #4871
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29374674/

Description (last modified by kzar)

Background

With #3692 we're adding a base ESLint configuration to the buildtools repository. Once that is finished we want to start using the configuration for the Chrome extension.

What to change

  • Update the buildtools dependency to include the ESLint configuration from #3692.
  • Update the ablockplusui dependency with the changes from #4871 so that ext isn't redeclared by adblockplusui/messageResponder.js.
  • Add a ESLint configuration to adblockpluschrome which inherits from it:
{
  "extends": "./buildtools/.eslintrc.json",
  "root": true,
  ...
}
  • Add an ESLint ignore file to ignore files such as jQuery.
  • Make the necessary changes to the adblockpluschrome code so that linting passes.
  • Add a note to the README explaining how to lint the code. (eslint *.js lib/ qunit/ ext/ chrome/)

Change History (2)

comment:1 Changed 3 years ago by kzar

  • Blocked By 4871 added

comment:2 Changed 3 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.