Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#4875 closed change (fixed)

Change app_id paremeter names for Microsoft Edge builds

Reported by: oleksandr Assignee: oleksandr
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29374919/

Description

Background

In #4865 we have changed app_id in Microsoft Edge builds to be either app_id_release or app_id_devbuild. We need to update the buildtools and adapt to the change.

What to change

Update the buildtools dependency and add app_id_release and app_id_devbuild.

Change History (4)

comment:1 Changed 3 years ago by oleksandr

  • Summary changed from Change app_id values for Microsoft Edge builds to Change app_id paremeter names for Microsoft Edge builds

comment:2 Changed 3 years ago by abpbot

comment:3 Changed 3 years ago by oleksandr

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

comment:4 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Both build names are already in the Store and name in correct in AppManifest.xml when building locally.

adblockpluschrome / 1846:44197859df84

Note: See TracTickets for help on using tickets.