Opened 3 years ago

Closed 3 years ago

#4882 closed change (fixed)

Rename flake8-abp to flake8-eyeo

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kzar, kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29375591/
https://codereview.adblockplus.org/29375654/
https://codereview.adblockplus.org/29375657/
https://codereview.adblockplus.org/29375660/
https://codereview.adblockplus.org/29375663/
https://codereview.adblockplus.org/29375666/

Description

Background

During the implementation of eslint-config-eyeo (#3692, our JavaScript linter configuration) we decided against the -abp, for the -eyeo, suffix. This has been established as not all of the code to be linted is part of Adblock Plus, but always developed by Eyeo. This is even more true for our Python code. Hence we decided to rename flake8-abp to flake8-eyeo as well.

What to change

  • Rename flake-abp to flake8-eyeo, in the codingtools repository.
  • Adapt the deps in the tox.ini of sitescripts, buildtools, cms and python-abp.
  • Adapt the link on https://adblockplus.org/coding-style.

Change History (10)

comment:1 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)

comment:3 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)

comment:4 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4882 - Renamed flake8-abp to flake8-eyeo

comment:5 Changed 3 years ago by abpbot

comment:7 Changed 3 years ago by abpbot

comment:8 Changed 3 years ago by abpbot

comment:9 Changed 3 years ago by abpbot

comment:10 Changed 3 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.