Opened 3 years ago

Closed 3 years ago

#4903 closed change (fixed)

Allow to specify file system root

Reported by: asmirnov Assignee: asmirnov
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29375826/

Description

Background

By default 'AdblockHelper' uses app cache dir (context.getCacheDir()) as file system root. This may be not desired as it can be cleared by the system.

What to change

We need to provide path argument to be more flexible.
It would be better not to break back compatibility.

Change History (4)

comment:1 Changed 3 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by asmirnov

  • Priority changed from P3 to P2

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4903 - Allow to specify file system root

comment:4 Changed 3 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.