#4907 closed change (fixed)

Update v8 to 5.7.278 in libadblockplus

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd, eric Blocked By: #4906, #4932, #4933, #4999, #5119, #5125
Blocking: #4194, #5267 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29451722/

Description

We need a recent version of v8 but we cannot update to the version in #1197 because of linking issues, #4062. However, recently v8 got rid of requirement for stlport and now we can link it statically, the next chosen version is 5.7.278 because it's possible to compile it for windows and android.

What to change

  • code and building infrastructure in libadblockplus
  • satisfy all dependencies, e.g. create local mirrors of required repos

Additional info

  • it requires to switch to MS Visual Studio 2015 (community edition is enough)
  • android ndk 12b

Change History (14)

comment:1 Changed 18 months ago by sergz

  • Component changed from Libadblockplus-Android to Libadblockplus

comment:2 Changed 18 months ago by eric@…

Sergei, about a year ago you were the one that changed #1197 to have a version number of v8 in the title:

https://issues.adblockplus.org/ticket/1197#comment:18

It's something of a misrepresentation to say we can't use the version in that ticket, since you were the one that changed it to have a version number in the first place. Please go change #1197 again to use the version number you want to use and close this ticket. It's clouding the actual history here to have another ticket for the same issue.

#1197 languished long enough that Visual Studio 2013 was superseded by Visual Studio 2015 and is about to be superseded by Visual Studio 2017. As long as you're changing #1197, we should update the stated VS requirement to 2017. The compiler continues to improve, with better language support and more correct and efficient STL implementation. VS 2017 will be released March 7, sooner than we'll be ready to update v8.

https://blogs.msdn.microsoft.com/visualstudio/2017/02/09/visual-studio-2017-launch-event-and-20th-anniversary/

comment:3 Changed 18 months ago by eric@…

  • Cc eric added

comment:4 Changed 18 months ago by sergz

I think these tickets are different.
The main aim of #1197 is to change the version of visual studio, and I have added the version of v8 in the title only for reference, however the issue #4907 is to update v8, and updating of visual studio is merely consequences which may not happen.

If I change the title of #1197, I will also have to change its description and the comments may sound a bit inconsistent. In this case, I think, the history will be indeed very cloudy. So, for the sake of simple history I would like to to have them both, and rather add the comment that it has been superseded by #4907 because the latter implies a higher version of Visual studio and either close #1197 or change #1197 to update to visual studio 2017 with removing of version of v8.

comment:5 Changed 18 months ago by sergz

  • Blocked By 4932 added

comment:6 Changed 18 months ago by sergz

  • Blocked By 4933 added

comment:7 Changed 17 months ago by sergz

  • Blocked By 4999 added

comment:8 Changed 16 months ago by sergz

  • Blocked By 5125 added

comment:9 Changed 15 months ago by sergz

  • Blocking 5267 added

comment:10 Changed 15 months ago by sergz

  • Blocking 4194 added

comment:11 Changed 15 months ago by sergz

  • Blocked By 5119 added

comment:12 Changed 15 months ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:13 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 4907 - Update v8 to 5.7.278 in libadblockplus

comment:14 Changed 14 months ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.