Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#4915 closed change (fixed)

Expose ext.i18n for background pages

Reported by: wspee Assignee: wspee
Priority: P2 Milestone: Adblock-Plus-2.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #4716, #5055 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29370594/
https://codereview.adblockplus.org/29376555/

Description (last modified by trev)

Background

#3672 moves lib/antiadblockInit.js from adblockpluscore to adblockplusui and uses ext.i18n.getMessage instead of Utils.getString for translation. In firefox ext.i18n is only available for content so we need to expose it to background as well.

What to change

Expose ext.i18n to background so lib/antiadblockInit.js can use ext.i18n.getMessage instead of Utils.getString.

What to test

This change affects anti-adblock notification, it should be tested along with other changes in #5055.

Change History (12)

comment:1 Changed 3 years ago by wspee

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by wspee

  • Description modified (diff)

comment:3 Changed 3 years ago by wspee

  • Blocking 4716 added
  • Description modified (diff)

comment:4 Changed 3 years ago by wspee

  • Review URL(s) modified (diff)

comment:5 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4915 - Define ext for background pages in antiadblockInit.js

comment:6 Changed 3 years ago by trev

  • Blocking 5055 added

comment:7 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4915 - Expose ext.i18n for background pages

comment:8 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 3 years ago by trev

  • Ready set

comment:10 Changed 3 years ago by trev

  • Priority changed from Unknown to P2

comment:11 Changed 3 years ago by trev

  • Description modified (diff)

comment:12 Changed 2 years ago by Ross

  • Verified working set

Done/implemented. Anti-adblock notification works as expected after changes.

ABP 2.8.2.4246-beta
Firefox 51 / 53 / Beta (54.0b2)
Windows 7

Note: See TracTickets for help on using tickets.