#4917 closed change (fixed)

Shrink space around accent section headings and content when section contains cards on acceptableads.com

Reported by: juliandoucette Assignee: ire
Priority: P2 Milestone: acceptableads.com/committee cleanup
Module: Websites Keywords:
Cc: jeen, athornburgh, saroyanm, scheer, rraceanu Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29457564/

Description

Background

Accent (green) section content (headings, paragraphs) have extra large padding on acceptableads.com. I think this makes sense when the section contains just a heading or quote. But not when the section contains cards too. e.g.

What to change

Reduce the amount of space under headings/content within accent sections that contain cards.

See attachments for an example using 50% as much space below.

Attachments (6)

Screen Shot 2017-02-20 at 14.25.15-fullpage.png (692.1 KB) - added by juliandoucette 20 months ago.
Desktop example 1
Screen Shot 2017-02-20 at 14.26.10-fullpage.png (409.6 KB) - added by juliandoucette 20 months ago.
Mobile example 1
Screen Shot 2017-02-20 at 14.26.26-fullpage.png (450.0 KB) - added by juliandoucette 20 months ago.
Tablet example 1
Screen Shot 2017-02-20 at 14.28.09-fullpage.png (546.1 KB) - added by juliandoucette 20 months ago.
Desktop example 2
Screen Shot 2017-02-20 at 14.28.15-fullpage.png (444.6 KB) - added by juliandoucette 20 months ago.
Tablet example 2
Screen Shot 2017-02-20 at 14.28.19-fullpage.png (473.1 KB) - added by juliandoucette 20 months ago.
Mobile example 2

Download all attachments as: .zip

Change History (16)

Changed 20 months ago by juliandoucette

Desktop example 1

Changed 20 months ago by juliandoucette

Mobile example 1

Changed 20 months ago by juliandoucette

Tablet example 1

Changed 20 months ago by juliandoucette

Desktop example 2

Changed 20 months ago by juliandoucette

Tablet example 2

Changed 20 months ago by juliandoucette

Mobile example 2

comment:1 Changed 20 months ago by juliandoucette

Sorry about the large screenshots :(

I'll resize them if you think it's necessary.

comment:2 Changed 20 months ago by juliandoucette

  • Milestone set to acceptableads.com/committee 160301
  • Ready set

Product approved via email.

comment:3 Changed 20 months ago by juliandoucette

  • Cc scheer rraceanu added

comment:4 Changed 20 months ago by juliandoucette

  • Milestone changed from acceptableads.com/committee 160301 to acceptableads.com/committee 160315

comment:5 Changed 20 months ago by juliandoucette

  • Milestone changed from acceptableads.com/committee 160315 to acceptableads.com/committee 160315 cleanup

comment:6 Changed 19 months ago by juliandoucette

  • Priority changed from Unknown to P2

Prioritizing because this effects other issues.

comment:7 Changed 17 months ago by ire

  • Owner set to iaderinokun

comment:8 Changed 17 months ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed 16 months ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.