Opened 2 years ago

Closed 2 years ago

Last modified 4 months ago

#4919 closed change (fixed)

Make getBackupFiles in lib/filterStorage.js asynchronous

Reported by: kzar Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: trev, sebastian, wspee Blocked By:
Blocking: #5048 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29397586/

Description

Background

The getBackupFiles function in lib/filterStorage.js currently has a comment // TODO: This method should be asynchronous. Since we're now beginning to use ESLint for the codebase (#4878) we need to remove that comment.

What to change

Make getBackupFiles asynchronous.

Change History (7)

comment:1 Changed 2 years ago by trev

The other option is to remove that functionality. As it is now, we only create automatic backups on Firefox, on all other platforms we cannot do it because of storage space (and UI) limitations. Given that the Firefox codebase is going away, improving this would be pointless.

comment:2 Changed 2 years ago by sebastian

Well, Adblock Plus for Safari is deprecated and no longer targeted by adblockpluscore, Microsoft Edge is about to lift their storage limitations with the upcoming Windows Creators Update, and as far as I can tell, there are no storage limitations on Chrome and Firefox with WebExtensions.

But the UI argument remains. If there is no plan to add this backup functionality to the new options page, there is not much of a point to keep this logic around or to even improve it. To clarify, is this about backups stored inside the extension, or about backups to be exported out of the browser?

comment:3 Changed 2 years ago by trev

  • Blocking 5048 added
  • Owner set to trev
  • Priority changed from Unknown to P2
  • Ready set

This is blocking #5048 now - not going via io.js here means that our legacy extension cannot use WebExtensions storage.

comment:4 Changed 2 years ago by wspee

  • Cc wspee added

comment:5 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by abpbot

comment:7 Changed 2 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.