Opened 5 years ago

Closed 3 years ago

#492 closed change (rejected)

Implement content blockers to block popups and XMLHttpRequests on Safari

Reported by: sebastian Assignee:
Priority: P4 Milestone:
Module: Platform Keywords:
Cc: arthur Blocked By:
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sebastian)

Background

Popups and XMLHttpRequests aren't blocked on Safari, since this wasn't possible so far. However, Safari 9 introduces content blockers that lift these limitations. Though this mechanism has quite some other limitations and issues.

So we might want to stick to the old mechanism based on the beforeload DOM event for other means of request blocking, while using the new mechanism to block popups and XMLHttpRequests.

What to change

Use content blockers on Safari 9+ to block popups and XMLHttpRequests.

Change History (9)

comment:1 Changed 5 years ago by sebastian

  • Ready set

comment:2 Changed 5 years ago by arthur

  • Cc arthur added

Let me know if you need more example sites.

comment:3 Changed 5 years ago by sebastian

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

I tested following cases which are blocked by EasyList Germany:

But we probably should test some more cases. Please also test popup blocking on Chrome, since that code has changed too (in order to share some code between Chrome and Safari).

comment:4 Changed 5 years ago by arthur

Sure, will do once it's in the dev build.

comment:5 Changed 5 years ago by philll

  • Platform set to Safari

comment:6 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from reviewing to reopened
  • Tester set to Unknown

I removed the patch. Beside it has been in review for almost 1.5 years without any progress, the new content blocking mechanism seems to be a better the way to go to implement popup blocking.

comment:7 Changed 4 years ago by sebastian

  • Description modified (diff)
  • Owner sebastian deleted
  • Priority changed from P3 to P4
  • Summary changed from Implement popup blocking in Safari to Implement content blockers to block popups and XMLHttpRequests

comment:8 Changed 4 years ago by sebastian

  • Summary changed from Implement content blockers to block popups and XMLHttpRequests to Implement content blockers to block popups and XMLHttpRequests on Safari

comment:9 Changed 3 years ago by sebastian

  • Resolution set to rejected
  • Status changed from reopened to closed

We decided to go with a complete implementation of the content blocker mechanism instead, see #3687.

Note: See TracTickets for help on using tickets.