Opened 3 years ago

Closed 2 years ago

#4920 closed change (fixed)

Add "Ready for Windows" section to adblockplus.org

Reported by: oleksandr Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: saroyanm, julian, jeen, lisabielik, jnink, athornburgh Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29458622/

Description (last modified by juliandoucette)

Background

We would like to get certified for Ready for Windows. To do that we need to have a statement on our website that our ABP for IE does indeed support Windows 10. There is more info about the requirement here

What to change

Add this text to IE specific page:

Adblock Plus for Internet Explorer is supported by eyeo GmbH on the following editions of Windows 10 – Windows 10 Pro, Windows 10 Education and Windows 10 Enterprise. Adblock Plus for Internet Explorer is supported on the in-market supported servicing branches of Windows 10 including - Current Branch, Current Branch for Business and the following Long-Term Servicing branch: Windows 10.

Approvals

[x] Content
[x] Legal
[x] Product

Attachments (1)

abp_homepage_ie.png (977.6 KB) - added by jeen 3 years ago.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 3 years ago by saroyanm

  • Cc jeen lisabielik jnink added

I think this kind of requests should go through the product team first, CCing people that might be involved.

comment:2 Changed 3 years ago by jeen

Trying to understand this - can this be anywhere on the website? Are there any restrictions on where this has to be displayed?

I.e. can we add this to our terms of use (@jnink - is this is even the relevant place for it? Maybe it should go somewhere else?)

The most relevant IE specific area on the current website is within the Learn More expandable area on the homepage. However, we are redesigning the homepage and this section will be removed. Therefore, I'm trying to understand if there is a better place we could be putting browser-specific information and if there is any other browser-specific information I should be aware of?

comment:3 Changed 3 years ago by jnink

@jeen: Let's keep it out of the terms of use. It is more a technical statement rather than a legal. They don't state any placement requirements but from my understanding it is something related to ABP itself. Thus, I recommend to include it somewhere on the download page.

comment:4 Changed 3 years ago by jnink

  • Description modified (diff)

comment:5 Changed 3 years ago by jnink

Changed the statement text as aligned with @oleksandr. LGTM now.

comment:6 Changed 3 years ago by juliandoucette

  • Description modified (diff)
  • Keywords goodfirstbug added
  • Summary changed from Add text for "Ready for Windows" certification to adblockplus.org to Add "Ready for Windows" section to adblockplus.org

Added approvals. Please update if I missed something.

@Jeen I get the impression that he wants an IE only notice (like our fr only and maxthon only notices) on the homepage and other download pages.

comment:7 Changed 3 years ago by lisabielik

Is 12:33 PM supposed to be in the last sentence?

comment:8 Changed 3 years ago by oleksandr

  • Description modified (diff)

No. Removed it. Thanks, Lisa.

comment:9 Changed 3 years ago by lisabielik

  • Description modified (diff)

comment:10 Changed 3 years ago by lisabielik

@oleksandr @juliandoucette

Is there anything blocking this ticket?

comment:11 follow-up: Changed 3 years ago by juliandoucette

Is there anything blocking this ticket?

Design/Wireframes and product approval.

comment:12 in reply to: ↑ 11 Changed 3 years ago by lisabielik

Replying to juliandoucette:

Is there anything blocking this ticket?

Design/Wireframes and product approval.

I thought this was just supposed to be a "note" added to the homepage? @Oleksandr, can you confirm?

Also adding Aaron to the ticket for the Product part.

comment:13 Changed 3 years ago by lisabielik

  • Cc athornburgh added

comment:14 Changed 3 years ago by oleksandr

This is supposed to be just a note.

Changed 3 years ago by jeen

comment:15 Changed 3 years ago by jeen

I've just added a mockup - the notification should go just above the footer and be styled in the same way as the messaging for Adblock Browser.

Consider it approved by Product.

comment:16 Changed 3 years ago by juliandoucette

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

Another fancy conditional homepage message!

@oleksandr I have prioritized this issue P3. Please let me know if you think it should be P2 (if you want to apply for Ready for Windows soon).

comment:17 Changed 2 years ago by ire

  • Owner set to iaderinokun

comment:18 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:19 Changed 2 years ago by juliandoucette

Does this apply to IE and Edge or just IE?

comment:20 Changed 2 years ago by oleksandr

This applies to IE only.

comment:21 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4920 - Add "Ready for Windows" section to adblockplus.org

comment:22 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.