Changes between Initial Version and Version 3 of Ticket #492


Ignore:
Timestamp:
05/16/2014 10:02:35 AM (6 years ago)
Author:
sebastian
Comment:

I tested following cases which are blocked by EasyList Germany:

But we probably should test some more cases. Please also test popup blocking on Chrome, since that code has changed too (in order to share some code between Chrome and Safari).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #492

    • Property Ready set
    • Property Cc arthur added
    • Property Status changed from new to reviewing
  • Ticket #492 – Description

    initial v3  
    11=== Background === 
    2 We don't support `$popup` filters in Safari yet. 
     2`$popup` filters aren't implemented in Safari yet. Hence users still see popup ads. 
    33 
    44=== What to change === 
    5 Implement popup blocking on Safari. Move `chrome.webNavigation.onWebNavigationTargetCreated` to the abstraction layer. And port that event to Safari by using content scripts. 
     5Implement popup blocking for Safari. Therefore move the Chrome specific code to the abstraction layer and add an implementation for Safari, in order to share the code doing the actual blocking. 
  • Ticket #492 – Review URL(s)

    initial v3  
     1http://codereview.adblockplus.org/5203459900964864