Opened 6 years ago

Last modified 5 years ago

#492 closed change

Implement popup blocking in Safari — at Version 3

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone:
Module: Platform Keywords:
Cc: arthur Blocked By:
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sebastian)


$popup filters aren't implemented in Safari yet. Hence users still see popup ads.

What to change

Implement popup blocking for Safari. Therefore move the Chrome specific code to the abstraction layer and add an implementation for Safari, in order to share the code doing the actual blocking.

Change History (3)

comment:1 Changed 6 years ago by sebastian

  • Ready set

comment:2 Changed 6 years ago by arthur

  • Cc arthur added

Let me know if you need more example sites.

comment:3 Changed 6 years ago by sebastian

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

I tested following cases which are blocked by EasyList Germany:

But we probably should test some more cases. Please also test popup blocking on Chrome, since that code has changed too (in order to share some code between Chrome and Safari).

Note: See TracTickets for help on using tickets.