Opened 5 years ago

Closed 2 years ago

#493 closed change (rejected)

Validate custom filters in Firefox

Reported by: sebastian Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: smultron45@… Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

Currently you can add filters with invalid CSS selectors that lead to warnings when applied.

What to change

Make sure that the CSS selector of element hiding filters added by the user is valid. Otherwise reject saving them.

Change History (6)

comment:1 Changed 5 years ago by mapx

  • Cc smultron45@… added

comment:2 Changed 5 years ago by sebastian

  • Ready set

comment:3 Changed 5 years ago by philll

  • Platform set to Firefox

comment:4 Changed 5 years ago by sebastian

  • Blocked By 1583 added

comment:5 Changed 5 years ago by sebastian

  • Blocked By 1583 removed

comment:6 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.