Opened 2 years ago

Closed 2 years ago

#4931 closed change (fixed)

add possibility to not send data depending on connection properties

Reported by: sergz Assignee: sergz
Priority: P1 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd, anton, oleksandr Blocked By: #4944
Blocking: #4948 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29377570/

Description

Background

We need an option to configure our engine to not use network in certain circumstances, e.g. when connection is metered.

Why in libadblockplus

Ideally it should be in adblockpluscore, however it will take too long to land it there but in libadblockplus we can get it done much faster and anyway we will have to have such API in libadblockplus.

What to change

Add method to JsEngine allowing to set a callback verifying whether the current connection is allowed or not. If this callback is empty then request is always allowed.
In calling network request method return error if method is not allowed.

Change History (6)

comment:1 Changed 2 years ago by sergz

  • Blocked By 4944 added

comment:2 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by oleksandr

  • Cc oleksandr added

comment:4 Changed 2 years ago by asmirnov

  • Blocking 4948 added

comment:6 Changed 2 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.