Opened 5 years ago

Closed 18 months ago

#494 closed change (rejected)

Validate custom filters in Element Hiding Helper

Reported by: sebastian Assignee:
Priority: P3 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

Currently you can add filters with invalid CSS selectors that lead to warnings when applied.

What to change

Make sure that the custom CSS selector specified in advanced mode in the Element Hiding Helper is valid. Otherwise reject saving the filter.

Change History (2)

comment:1 Changed 5 years ago by sebastian

  • Ready set

comment:2 Changed 18 months ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.

Note: See TracTickets for help on using tickets.