Opened 3 years ago

Closed 3 years ago

#4942 closed defect (fixed)

Failed to build due to "sorry, unimplemented: mangling dotstar_expr"

Reported by: asmirnov Assignee: asmirnov
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: sergz, fhd Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29377054/

Description

Environment

Trying to build libadblockplus-android on new macbook i'm getting "sorry, unimplemented: mangling dotstar_expr" error (see full text in attached build_error.txt) with gradlew. Something related to issue #768

How to reproduce

  1. Run ./gradlew clean assembleDebug
  2. Get build error

...

Observed behaviour

The project should be built

Expected behaviour

The project build fails on ndk compilation

Attachments (1)

build_error.txt (44.9 KB) - added by asmirnov 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by asmirnov

comment:1 Changed 3 years ago by asmirnov

this can be fixed by using one of the lines in https://hg.adblockplus.org/libadblockplus-android/file/tip/libadblockplus-android/jni/Application.mk:
1) NDK_TOOLCHAIN_VERSION := clang (use clang toolchain)
2) NDK_TOOLCHAIN_VERSION := 4.8 (use gcc toolchain version 4.8)

The preferred solution will be discussed with Sergei (in order to have the same toolchain for both libadblockplus and libadblockplus-android

comment:3 Changed 3 years ago by asmirnov

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.