Opened 2 years ago

Last modified 21 months ago

#4961 closed change

Fix card group field alignment on acceptableads.com — at Version 4

Reported by: juliandoucette Assignee:
Priority: P2 Milestone: acceptableads.com/committee cleanup
Module: Websites Keywords:
Cc: athornburgh, saroyanm, scheer, rraceanu Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29453600/, https://jsfiddle.net/euhvz27m/3/, https://codereview.adblockplus.org/29442559/

Description (last modified by saroyanm)

Background

We have several card groups that do not resize well because we set fixed heights per device size. This works OK for now, but it's unlikely that this will work with translations and future blog posts.

Examples

What to change

Find a way to dynamically size these card group rows across device sizes without breaking field alignment.

Change History (4)

comment:1 Changed 2 years ago by juliandoucette

  • Milestone changed from acceptableads.com/committee 160315 to acceptableads.com/committee 160315 cleanup

comment:2 Changed 2 years ago by saroyanm

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

I think this is ready.

comment:3 Changed 2 years ago by saroyanm

Just for testing reason: https://jsfiddle.net/euhvz27m/1/

Last edited 2 years ago by saroyanm (previous) (diff)

comment:4 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)

I added a solution into the review section, will update it accordingly with progress.

Note: See TracTickets for help on using tickets.