Opened 9 months ago

Closed 9 months ago

#4974 closed defect (fixed)

HTMLCollection iterator workaround for old Chrome versions missing from popup window

Reported by: Ross Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-1.13-for-Chrome-Opera
Module: Platform Keywords:
Cc: kzar, trev, rraceanu Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29379782/

Description (last modified by kzar)

Environment

ABP 1.12.4.1739

Chrome 49 but not in 56.
Opera 37 but not in 41.

How to reproduce

  1. Install Adblock Plus
  2. Open popup, inspect and open Console.

Observed behaviour

JavaScript error is displayed:

    Uncaught TypeError: document.getElementsByClassName(...)[Symbol.iterator] is not a function popup.js:78

Expected behaviour

JavaScript error not to occur.

Notes

HTMLCollection in older versions of Chrome does not have iterator support. We have a workaround in ext/common.js but we forgot to include that in the popup window too.

Change History (5)

comment:1 Changed 9 months ago by Ross

  • Description modified (diff)

comment:2 Changed 9 months ago by kzar

  • Cc trev added
  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Milestone set to Adblock-Plus-1.13-for-Chrome-Opera
  • Owner set to kzar
  • Priority changed from Unknown to P1
  • Ready set
  • Review URL(s) modified (diff)
  • Summary changed from Popup.js error to HTMLCollection iterator workaround for old Chrome versions missing from popup window

comment:3 Changed 9 months ago by kzar

  • Status changed from new to reviewing

comment:4 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 4974 - Include HTMLCollection iterator workaround for popup

comment:5 Changed 9 months ago by kzar

  • Cc rraceanu added
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.