Opened 3 years ago

Closed 2 years ago

#4981 closed change (fixed)

Measure and improve test coverage of CMS

Reported by: kvas Assignee: jsonesen
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29383956

Description (last modified by jsonesen)

Background

Recently we have tried to improve the style guide conformance of a part of CMS code. Unfortunately it led to regressions that were not picked up by existing test suite and ended up in production. In order to mitigate similar situations in the future we would like to start measuring test coverage of CMS code and generating a line by line coverage report.

What to change

Add generation of a test coverage report (using pytest-cov) to the test suite of CMS. Further coverage of converters.py can be achieved by adding additional content to the test site such as link or scripts tags.

Change History (5)

comment:1 Changed 3 years ago by jsonesen

  • Owner set to jsonesen
  • Review URL(s) modified (diff)

comment:2 Changed 3 years ago by jsonesen

  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4981 - Adds test coverage report

comment:4 Changed 3 years ago by jsonesen

  • Description modified (diff)

comment:5 Changed 2 years ago by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.