Opened on 03/13/2017 at 02:28:08 PM

Closed on 07/28/2017 at 06:44:08 AM

#4983 closed defect (fixed)

Get rid of Sleep() in the WebRequest test

Reported by: hfiguiere Assignee: sergz
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):


We should remove the Sleep() in the WebRequest test and use instead either condition variables or promise.

See for the context.

Removing the global state variables too if possible.

Attachments (0)

Change History (5)

comment:1 Changed on 07/27/2017 at 10:21:06 AM by sergz

  • Review URL(s) modified (diff)

comment:2 Changed on 07/27/2017 at 10:21:15 AM by sergz

  • Owner set to sergz

comment:3 Changed on 07/27/2017 at 10:21:19 AM by sergz

  • Status changed from new to reviewing

comment:4 Changed on 07/28/2017 at 06:42:35 AM by abpbot

A commit referencing this issue has landed:
Issue 4983 - Get rid of Sleep() in the WebRequest test

comment:5 Changed on 07/28/2017 at 06:44:08 AM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.