Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#4988 closed change (fixed)

[emscripten] Adjust API for Element Hiding Emulation filters

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29383799/

Description (last modified by trev)

Background

#4394 introduced some changes in the way Element Hiding Emulation filters are represented in the API, these need to be reflected in the Emscripten-based classes as well.

What to change

  • CSSPropertyFilter should be renamed into ElemHideEmulationFilter.
  • Any filter containing the string [-abp-properties= is considered ElemHideEmulationFilter, no additional parsing should be performed.
  • The error code for missing domain specialization is filter_elemhideemulation_nodomain now.
  • ElemHideEmulationFilter.prototype.type should be elemhideemulation now. No further properties should be exposed compared to ElemHideBase.

Change History (6)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 follow-up: Changed 2 years ago by sergz

no additional parsing should be performed.

Just wonder, who will parse it and how is it supposed to be used in this case?

comment:3 Changed 2 years ago by trev

  • Description modified (diff)

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4988 - [emscripten Adjust API for Element Hiding Emulation filters]

comment:5 Changed 2 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 in reply to: ↑ 2 Changed 2 years ago by trev

Replying to sergz:

no additional parsing should be performed.

Just wonder, who will parse it and how is it supposed to be used in this case?

Our content script is parsing them now, so we only do the parsing when actually necessary.

Version 0, edited 2 years ago by trev (next)
Note: See TracTickets for help on using tickets.