Opened 3 years ago

Closed 3 years ago

#4989 closed change (fixed)

[emscripten] Move filter class files into a separate directory

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122, #4127 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29383816/

Description

Background

As implemented in #4125, all C++ files are currently located in the same directory. This won't scale, in particular once subscription classes are added.

What to change

Move filter classes into compiled/filter subdirectory, only leave generic files at the top level of compiled/ directory.

Change History (3)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4989 - [emscripten Move filter class files into a separate directory]

comment:3 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.