Opened 3 years ago

Closed 3 years ago

#4991 closed change (fixed)

[emscripten] Update to Emscripten 1.37.3

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29384673/

Description (last modified by trev)

Background

Our Emscripten efforts started a while ago, so we expected Emscripten 1.35.0. By now this version is outdated and current Emscripten versions produce smaller code sizes.

What to change

Make sure that a current Emscripten version (Emscripten 1.37.3) can be used.

Change History (4)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by trev

  • Blocking 4127 removed
  • Description modified (diff)

Not actually blocking #4127, using 64 bit integers for our purposes seems a bad idea regardless of the bug - these numbers are represented as floating point numbers on the JS side.

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4991 - [emscripten Update to Emscripten 1.37.3]

comment:4 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.