Changes between Initial Version and Version 1 of Ticket #5014


Ignore:
Timestamp:
03/19/2017 06:41:09 AM (4 years ago)
Author:
kzar
Comment:

I am not familiar with the localisation code but it appears the problem is caused by the ext.i18n.getMessage calls in antiadblockInit.js. For example ext.i18n.getMessage("notification_antiadblock_title") instead of ext.i18n.getMessage("global_notification_antiadblock_title"). Switching the calls to use Utils.getString instead, for example Utils.getString("notification_antiadblock_title"), seems to work for both adblockplus and adblockpluschrome. (I used my eslint-test branch for testing adblockplus.)

Unfortunately I think this problem might warrant a second emergency release. Worse still the ESLint changes already landed in adblockplusui which we definitely shouldn't include in such a release. So we will need to release using an earlier version of adblockplusui with the fix applied. I'll get a second review up now for that change to help speed things up.

Legend:

Unmodified
Added
Removed
Modified