Changes between Initial Version and Version 26 of Ticket #5015


Ignore:
Timestamp:
03/23/2017 06:36:47 AM (2 years ago)
Author:
kzar
Comment:

I agree we should handle this situation better. Like Wladimir mentions we can catch exceptions thrown by insertRule. When an exception is thrown we can insert a rule for each selector in the batch separately, so that only the broken ones are skipped.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5015

    • Property Status changed from new to reviewing
    • Property Cc kzar trev sebastian Ross scheer rraceanu mapx wspee added
    • Property Component changed from Unknown to Platform
    • Property Summary changed from Personal filters not working anymore to Element hiding completely breaks if there are any syntax errors in element hiding filters
    • Property Priority changed from Unknown to P2
    • Property Ready set
  • Ticket #5015 – Description

    initial v26  
    55 
    66=== How to reproduce === 
    7  1. Go to https://adblockplus.org/ 
    8  2. Click the ABP logo next to your address bar 
     7 1. Add Mapx's broken filter subscription http://axistrivia.altervista.org/list/easylist2.txt 
     8 2. Browse to https://adblockplus.org/ 
     9 3. Click the ABP logo next to your address bar 
    910 3. Select "Block element" 
    1011 4. Hover the ABP logo on the webpage at the top left corner 
    1112 5. The image becomes yellowish 
    1213 6. Click on it 
    13  7. A popup appears asking for confirmation : "Add filter(s) ?" with the following filters : 
    14      adblockplus.org###logo 
    15      adblockplus.org##.sprite 
     14 7. A popup appears asking for confirmation. 
    1615 8. Click Add 
    1716 
    1817=== Observed behaviour === 
    19 The selected logo doesn't disappear 
     18The selected logo doesn't disappear. 
     19 
     20Exceptions are shown in the developer console. 
    2021 
    2122=== Expected behaviour === 
    22 The selected logo disappears 
     23The selected logo disappears. 
  • Ticket #5015 – Review URL(s)

    initial v26  
     1https://codereview.adblockplus.org/29392555/