Opened 3 years ago

Last modified 3 years ago

#5020 closed change

[emscripten] Improve compile script — at Version 2

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29390650/
https://codereview.adblockplus.org/29390657/
https://codereview.adblockplus.org/29390663/
https://codereview.adblockplus.org/29392768/

Description (last modified by trev)

Background

The script currently used to compile Emscripten code was meant as a temporary solution and has a number of shortcomings that are easy to fix.

What to change

  • Make the script PEP-8 compliant.
  • Use os.path.join() consistently.
  • Don't use current directory, resolve paths relative to script directory instead.
  • Add command line option to set Emscripten path and only use ../emscripten as fallback.
  • Add --debug command line flag to disable code minification.
  • Add --tracing command line flag to enable memory tracing.
  • Implement a Windows-compatible solution to retrieve Emscripten environment.

Change History (2)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)

comment:2 Changed 3 years ago by trev

  • Description modified (diff)
Note: See TracTickets for help on using tickets.