Opened 2 years ago

Last modified 7 months ago

#5025 reopened change

Implement Filter Groups in AdBlock Plus for WebExtensions

Reported by: ExE Boss Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By: #5158
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

In AdBlock Plus for Firefox, custom filters are grouped into filter groups, which can be toggled on or off independently.

In AdBlock Plus for WebExtensions, all custom filters are one single group which can't be turned off without removing the filter(s).

Custom Filters Comparison (WebExtensions × Firefox)

I request that in AdBlock Plus for WebExtensions, the custom filters are changed to work similarly to the way they are implemented in AdBlock Plus for Firefox. (Grouped into filter groups and be toggle-able independently)

The reason for this is to provide feature parity in the WebExtension and the Firefox versions of AdBlock Plus ease the transition from a Bootstrapped extension to a WebExtension in AdBlock Plus for Firefox.

What to change

See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/28

Attachments (1)

Custom Filters Comparison (WebExtensions × Firefox).png (70.7 KB) - added by ExE Boss 2 years ago.
Custom Filters Comparison (WebExtensions × Firefox)

Download all attachments as: .zip

Change History (10)

Changed 2 years ago by ExE Boss

Custom Filters Comparison (WebExtensions × Firefox)

comment:1 Changed 2 years ago by ExE Boss

Summary should be: Implement Custom Filter Groups in AdBlock Plus for WebExtensions

comment:2 Changed 23 months ago by trev

  • Resolution set to duplicate
  • Status changed from new to closed

New options page for Chrome and WebExtensions is #2706, the current options page isn't meant to stay.

comment:3 Changed 23 months ago by trev

  • Cc trev added

comment:4 Changed 23 months ago by ExE Boss

It seems like you misunderstood what I mean.

I am talking about the new options page having the custom filters in a single filter list instead of multiple custom filter list groups.

I checked the issue you provided me with, and nowhere does it mention allowing the user to keep multiple custom filter lists. Instead, it seems like the plan is to have the new options page merge all the current custom filter list groups into a single large custom filter list.

comment:5 Changed 23 months ago by trev

  • Cc greiner added
  • Component changed from Unknown to User-Interface

@greiner: Do we currently have plans to implement organizing user filters as something better than a plain list? If not, maybe this should be reopened and block #2706.

comment:6 Changed 23 months ago by greiner

  • Blocked By 2706 added
  • Resolution duplicate deleted
  • Status changed from closed to reopened

@trev This is not part of #2706 which still refers to the milestone of having feature-parity with Chrome. There's no meta ticket for Firefox tickets we want to port over after that.

Anyway, I reopened it because there's no other ticket for it yet but leaving it as "not ready" due to it lacking information in regards to functionality, design and timeline. Those are somewhat blocked by (at least) the design finalization for #2706.

comment:7 Changed 22 months ago by greiner

  • Blocked By 5158 added; 2706 removed

comment:8 Changed 14 months ago by fhd

  • Cc trev removed

comment:9 Changed 7 months ago by greiner

  • Description modified (diff)

Added reference to GitLab issue.

Note: See TracTickets for help on using tickets.