Opened 2 years ago

Closed 2 years ago

#5030 closed defect (fixed)

Fix the disposing order

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus-Android Keywords:
Cc: asmirnov Blocked By:
Blocking: #5026 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29396579/

Description

It's about the function https://hg.adblockplus.org/libadblockplus-android/file/447a4bb3cb28/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java#l158.

Firstly we should dispose objects which are using other objects, so, firstly FilterEngine and JsEngine and only afterwards their dependencies.

Change History (4)

comment:1 Changed 2 years ago by sergz

  • Cc asmirnov added; anton removed

comment:2 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5030 - Fix the disposing order

comment:4 Changed 2 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.