Opened 3 years ago

Closed 3 years ago

#5035 closed defect (rejected)

Build breakage

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29394612/

Description (last modified by hfiguiere)

Build is broken on travis.

https://travis-ci.org/hfiguiere/libadblockplus/jobs/214782594

../src/JsEngine.cpp:113:45: error: no matching function for call to ‘std::list<AdblockPlus::JsEngine::TimerTaskInfo>::erase(std::list<AdblockPlus::JsEngine::TimerTaskInfo>::const_iterator&)’
   timerTaskInfos.erase(timerTaskInfoIterator);
                                             ^
../src/JsEngine.cpp:113:45: note: candidates are:
In file included from /usr/include/c++/4.8/list:64:0,
                 from ../include/AdblockPlus/JsEngine.h:23,
                 from ../include/AdblockPlus/FilterEngine.h:25,
                 from ../include/AdblockPlus.h:38,
                 from ../src/JsEngine.cpp:18:
/usr/include/c++/4.8/bits/list.tcc:108:5: note: std::list<_Tp, _Alloc>::iterator std::list<_Tp, _Alloc>::erase(std::list<_Tp, _Alloc>::iterator) [with _Tp = AdblockPlus::JsEngine::TimerTaskInfo; _Alloc = std::allocator<AdblockPlus::JsEngine::TimerTaskInfo>; std::list<_Tp, _Alloc>::iterator = std::_List_iterator<AdblockPlus::JsEngine::TimerTaskInfo>]
     list<_Tp, _Alloc>::
     ^
/usr/include/c++/4.8/bits/list.tcc:108:5: note:   no known conversion for argument 1 from ‘std::list<AdblockPlus::JsEngine::TimerTaskInfo>::const_iterator {aka std::_List_const_iterator<AdblockPlus::JsEngine::TimerTaskInfo>}’ to ‘std::list<AdblockPlus::JsEngine::TimerTaskInfo>::iterator {aka std::_List_iterator<AdblockPlus::JsEngine::TimerTaskInfo>}’
In file included from /usr/include/c++/4.8/list:63:0,
                 from ../include/AdblockPlus/JsEngine.h:23,
                 from ../include/AdblockPlus/FilterEngine.h:25,
                 from ../include/AdblockPlus.h:38,
                 from ../src/JsEngine.cpp:18:
/usr/include/c++/4.8/bits/stl_list.h:1193:7: note: std::list<_Tp, _Alloc>::iterator std::list<_Tp, _Alloc>::erase(std::list<_Tp, _Alloc>::iterator, std::list<_Tp, _Alloc>::iterator) [with _Tp = AdblockPlus::JsEngine::TimerTaskInfo; _Alloc = std::allocator<AdblockPlus::JsEngine::TimerTaskInfo>; std::list<_Tp, _Alloc>::iterator = std::_List_iterator<AdblockPlus::JsEngine::TimerTaskInfo>]
       erase(iterator __first, iterator __last)
       ^
/usr/include/c++/4.8/bits/stl_list.h:1193:7: note:   candidate expects 2 arguments, 1 provided
../src/JsEngine.cpp: In member function ‘AdblockPlus::JsValuePtr AdblockPlus::JsEngine::NewCallback(v8::InvocationCallback)’:
../src/JsEngine.cpp:226:30: warning: ‘static v8::Local<v8::FunctionTemplate> v8::FunctionTemplate::New(v8::InvocationCallback, v8::Handle<v8::Value>, v8::Handle<v8::Signature>, int)’ is deprecated (declared at ../third_party/v8/include/v8.h:3354) [-Wdeprecated-declarations]
       v8::External::New(data));
                              ^
make[1]: *** [out/Debug/obj.target/libadblockplus/src/JsEngine.o] Error 1
make[1]: Leaving directory `/home/travis/build/hfiguiere/libadblockplus/build'
make: *** [all] Error 2

Change History (6)

comment:1 Changed 3 years ago by hfiguiere

  • Description modified (diff)

comment:2 Changed 3 years ago by hfiguiere

  • Description modified (diff)

comment:3 Changed 3 years ago by hfiguiere

std::list<>::erase() changed signature in C++11 and one of the travis CI build config use an older compiler.... :-/

Last edited 3 years ago by hfiguiere (previous) (diff)

comment:4 Changed 3 years ago by hfiguiere

  • Summary changed from Buld breakage to Build breakage

comment:5 Changed 3 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 3 years ago by hfiguiere

  • Resolution set to rejected
  • Status changed from reviewing to closed

We don't support gcc 4.8 at that point.

The CI scripts have been fixed to reflect this.

Closing. WONTFIX.

Note: See TracTickets for help on using tickets.