Opened 3 years ago

Closed 3 years ago

#5037 closed change (fixed)

Look for "[-abp-properties=" rather than "[-abp-properties" in order to recognize CSS property filters

Reported by: hfiguiere Assignee: hfiguiere
Priority: P4 Milestone:
Module: Core Keywords:
Cc: trev, fhd Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29395678/

Description (last modified by trev)

Background

In #4394 we stopped parsing CSS property filters in Core, now the content script is responsible for that. However, Core still needs to recognize CSS property filters and currently it uses the string "[-abp-properties" for that.

What to change

Use "[-abp-properties=" to recognize CSS properties (with = sign) which is slightly more logical and slightly less prone to false positives.

Change History (6)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)
  • Priority changed from Unknown to P4
  • Summary changed from -abp-properties filter lookup needs to include '=' to Look for "[-abp-properties=" rather than "[-abp-properties" in order to recognize CSS property filters
  • Type changed from defect to change

comment:2 Changed 3 years ago by trev

  • Ready set

comment:3 Changed 3 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 years ago by hfiguiere

  • Owner set to hfiguiere

comment:5 Changed 3 years ago by abpbot

comment:6 Changed 3 years ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.