Opened on 03/26/2017 at 03:59:25 PM

Closed on 03/27/2017 at 03:14:35 PM

#5037 closed change (fixed)

Look for "[-abp-properties=" rather than "[-abp-properties" in order to recognize CSS property filters

Reported by: hfiguiere Assignee: hfiguiere
Priority: P4 Milestone:
Module: Core Keywords:
Cc: trev, fhd Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by trev)


In #4394 we stopped parsing CSS property filters in Core, now the content script is responsible for that. However, Core still needs to recognize CSS property filters and currently it uses the string "[-abp-properties" for that.

What to change

Use "[-abp-properties=" to recognize CSS properties (with = sign) which is slightly more logical and slightly less prone to false positives.

Attachments (0)

Change History (6)

comment:1 Changed on 03/27/2017 at 07:53:05 AM by trev

  • Description modified (diff)
  • Priority changed from Unknown to P4
  • Summary changed from -abp-properties filter lookup needs to include '=' to Look for "[-abp-properties=" rather than "[-abp-properties" in order to recognize CSS property filters
  • Type changed from defect to change

comment:2 Changed on 03/27/2017 at 07:55:41 AM by trev

  • Ready set

comment:3 Changed on 03/27/2017 at 02:40:32 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 03/27/2017 at 02:41:38 PM by hfiguiere

  • Owner set to hfiguiere

comment:5 Changed on 03/27/2017 at 03:13:07 PM by abpbot

comment:6 Changed on 03/27/2017 at 03:14:35 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Note: See TracTickets for help on using tickets.