Opened 2 years ago

Closed 2 years ago

#5040 closed defect (fixed)

Allowed connection type is not saved.

Reported by: sergz Assignee: sergz
Priority: P1 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov, fhd, hfiguiere Blocked By:
Blocking: #4948 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29397596/

Description

The main issue is that the saving procedure is not triggered when that value is set because there is no default value for that value.

What to change

Add a default value and add yet one settings indicating whether it's a null value as a hack because of #5039. I would prefer to have a hack as two setting values right now internally and a proper API than to change API later.

Change History (5)

comment:1 Changed 2 years ago by asmirnov

  • Blocking 4948 added

comment:2 Changed 2 years ago by sergz

  • Blocked By 5039 added

comment:3 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5040 - fix saving of allowed_connection_type preference

comment:5 Changed 2 years ago by sergz

  • Blocked By 5039 removed
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.