Opened on 03/28/2017 at 08:02:01 AM

Closed on 03/29/2017 at 11:51:04 AM

#5040 closed defect (fixed)

Allowed connection type is not saved.

Reported by: sergz Assignee: sergz
Priority: P1 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov, fhd, hfiguiere Blocked By:
Blocking: #4948 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):


The main issue is that the saving procedure is not triggered when that value is set because there is no default value for that value.

What to change

Add a default value and add yet one settings indicating whether it's a null value as a hack because of #5039. I would prefer to have a hack as two setting values right now internally and a proper API than to change API later.

Attachments (0)

Change History (5)

comment:1 Changed on 03/28/2017 at 08:03:17 AM by asmirnov

  • Blocking 4948 added

comment:2 Changed on 03/28/2017 at 09:21:53 AM by sergz

  • Blocked By 5039 added

comment:3 Changed on 03/29/2017 at 11:04:26 AM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 03/29/2017 at 11:50:13 AM by abpbot

A commit referencing this issue has landed:
Issue 5040 - fix saving of allowed_connection_type preference

comment:5 Changed on 03/29/2017 at 11:51:04 AM by sergz

  • Blocked By 5039 removed
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.