Opened 3 years ago

Closed 3 years ago

#5049 closed change (fixed)

Allow embedded WebExtensions in gecko packager

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: wspee Blocked By:
Blocking: #5048 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29397581/

Description (last modified by trev)

Background

We need to add a WebExtension part to our current Adblock Plus for Firefox in order to migrate data.

What to change

Add webextension directory to the build if present. In that case, add <em:hasEmbeddedWebExtension>true</em:hasEmbeddedWebExtension> setting to install.rdf and start up WebExtension part in bootstrap.js. Modules of the legacy extension should be able to require("webextension") in order to get the promise returning a runtime.Port instance to communicate with the WebExtension part.

Change History (6)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)

comment:2 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by sebastian

  • Ready set

comment:4 Changed 3 years ago by wspee

  • Cc wspee added

comment:5 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5049 - Allow embedded WebExtensions in gecko packager

comment:6 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.