Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#5055 closed change (fixed)

Update adblockpluscore dependency to revision d0715e99bd3b and adblockplusui to 8ceaabb9c639

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #4915
Blocking: #5048 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29397620/

Description (last modified by trev)

Background

We need to update both dependencies at the same time because of #3672 which affects both.

From adblockpluscore this imports:

From adblockplusui this imports:

What to change

With the remaining part of #4915 resolved, the following changes should be necessary:

  • Adjust mapping for antiAdblockInit.js to make it imported from adblockplusui.
  • Calling handler.load() in lib/child/elemHideEmulation.js is no longer necessary, handler.apply() is sufficient.
  • Adjust EventTarget API for messageResponder (outlined under https://issues.adblockplus.org/ticket/4968#comment:10).

What to test

Due to massive changes in #4878 and #4871 all extension functionality needs to be retested. Focus areas are:

  • Anti-adblock notification
  • CSS property filters (display in blockable items list changed, now showing the effective selector in the "Address" column)
  • First-run page

Note that the extension should no longer install in Firefox 38 and 39, it isn't compatible with those due to changes on #4878. Everything should work in Firefox 40 however.

Change History (12)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)

comment:2 Changed 3 years ago by trev

  • Blocking 5048 added

comment:3 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 years ago by trev

  • Description modified (diff)

comment:6 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:9 Changed 3 years ago by trev

  • Description modified (diff)

comment:10 Changed 3 years ago by trev

  • Description modified (diff)

comment:11 Changed 2 years ago by Ross

Note: Minimum supported version is now Firefox 51 (#5222).

comment:12 Changed 2 years ago by Ross

  • Verified working set

All of the functionality I can think to test appears to be working correctly, specifically checked the anti-adblock notification, FRP, CSS property filters, blockable items list.

ABP 2.8.2.4246-beta
Firefox 51 / 53 / Dev (54) / Windows 7

Note: See TracTickets for help on using tickets.