Opened on 03/29/2017 at 12:08:40 PM

Closed on 03/29/2017 at 02:11:17 PM

Last modified on 05/23/2017 at 02:47:06 PM

#5055 closed change (fixed)

Update adblockpluscore dependency to revision d0715e99bd3b and adblockplusui to 8ceaabb9c639

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #4915
Blocking: #5048 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by trev)


We need to update both dependencies at the same time because of #3672 which affects both.

From adblockpluscore this imports:

From adblockplusui this imports:

What to change

With the remaining part of #4915 resolved, the following changes should be necessary:

  • Adjust mapping for antiAdblockInit.js to make it imported from adblockplusui.
  • Calling handler.load() in lib/child/elemHideEmulation.js is no longer necessary, handler.apply() is sufficient.
  • Adjust EventTarget API for messageResponder (outlined under

What to test

Due to massive changes in #4878 and #4871 all extension functionality needs to be retested. Focus areas are:

  • Anti-adblock notification
  • CSS property filters (display in blockable items list changed, now showing the effective selector in the "Address" column)
  • First-run page

Note that the extension should no longer install in Firefox 38 and 39, it isn't compatible with those due to changes on #4878. Everything should work in Firefox 40 however.

Attachments (0)

Change History (12)

comment:1 Changed on 03/29/2017 at 12:13:29 PM by trev

  • Description modified (diff)

comment:2 Changed on 03/29/2017 at 12:15:08 PM by trev

  • Blocking 5048 added

comment:3 Changed on 03/29/2017 at 12:30:28 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 03/29/2017 at 01:28:41 PM by trev

  • Description modified (diff)

comment:5 Changed on 03/29/2017 at 02:10:48 PM by abpbot

comment:6 Changed on 03/29/2017 at 02:11:17 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 03/29/2017 at 02:11:34 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:8 Changed on 03/30/2017 at 10:19:22 AM by abpbot

comment:9 Changed on 03/30/2017 at 10:20:21 AM by trev

  • Description modified (diff)

comment:10 Changed on 03/30/2017 at 10:21:01 AM by trev

  • Description modified (diff)

comment:11 Changed on 05/22/2017 at 12:17:46 PM by Ross

Note: Minimum supported version is now Firefox 51 (#5222).

comment:12 Changed on 05/23/2017 at 02:47:06 PM by Ross

  • Verified working set

All of the functionality I can think to test appears to be working correctly, specifically checked the anti-adblock notification, FRP, CSS property filters, blockable items list.

Firefox 51 / 53 / Dev (54) / Windows 7

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.