Opened 6 years ago

Closed 5 years ago

#506 closed change (rejected)

[Typed objects] Guard against integer overflow issues

Reported by: trev Assignee:
Priority: P5 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #145 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):



The current memory allocation implementation for typed objects doesn't guard against integer overflows. In particular, there can be at most 32768 buffers for each type but we will happily try to allocate more buffers.

What to change

Check where integer overflows can happen in the code and add guards to produce a meaningful error message in that case.

Change History (2)

comment:1 Changed 5 years ago by fhd

  • Priority changed from P2 to P5

Since the Emscripten based approach is looking rather good, I'm not sure we really want to continue to work on Typed Objects. Makes it a P5.

comment:2 Changed 5 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

In fact, at that point I am certain that we are dropping typed objects and go with Emscripten instead. The performance issues we had with Emscripten initially are bound to affect us with typed objects as well (important points: static generation of JS bindings, stack-based allocations, likely more). Fixing these issues was already non-trivial with Emscripten, but with our own toolchain it will require far more effort - this isn't going to pay off if we have a reasonable and maintained alternative.

Note: See TracTickets for help on using tickets.